[poco] Fix mingw compilation #42330
Merged
[poco] Fix mingw compilation #42330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
for test I created a project like below. I think it will be useful for reviewers. |
dg0yt
reviewed
Nov 23, 2024
|
I couldn't find any comprehensive resources on how to manage |
dg0yt
suggested changes
Nov 23, 2024
SeanTolstoyevski
force-pushed
the
fix_poco_mingw_compilation
branch
from
f606d7c
to
fab6121
Compare
Cheney-W
added
category:port-bug
Cheney-W
approved these changes
Nov 25, 2024
|
Thanks for the fix! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #38873
Fixes #39797
The development has been tested with
x64-mingw-staticandx86-mingw-staticand no issues have been observed.Due to the more patches in this port, I have scoped the patch specifically to this triplet, as it seemed more appropriate. This approach should not cause any issues for other triplets.